Replace test Task with Thread with increased stack size #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
approved these changes
Jan 26, 2025
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
Thanks! I guess this has the added advantage that it'll try to abort on .NET Framework?
Member
Author
I suppose so. Although we had misconfigured long tasks in the past that were timing out prematurely, my understanding is that the timeout is here to prevent the whole test run to hang indefinitely because of one misbehaving test. If so, the thread will never complete and basically hang on to its resources until the whole process terminates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the stack size used by the thread running tests to 2 MiB. Reportedly the stack size of background treads on .NET 8.0 on macOS is extremely small (0.5 MiB), so it is easy to hit the limit.
This is essentially the last commit from #1879, which does not belong there but I pushed it there to test it with CI. I could not reproduce the stack overflow locally, probably because I develop on ARM which extensively uses registers for parameter passing so its stack usage is lower than on x64. Once this PR is merged, I will rebase #1879 on top of the current main branch (sans the last commit) and presumably the tests will pass.